While attending the University of Virginia, Neff captained the 1907 football team. After obtaining his M.D. in 1910, Neff worked at the University of Virginia Hospital first as an intern and surgeon and then later as professor of urology. He was also a member of the Southern Surgical Association, for which he served as vice president from 1934 until his death in 1938.