{{raw "When You're Smiling" is a song by Larry Shay, Mark Fisher, and Joe Goodwin (June 6, 1889 - July 31, 1943), and made famous by Louis Armstrong, who recorded it at least three times, in 1929, 1932, and 1956. Duke Ellington also recorded it several times earlier in his career.