Their relationship is more like family. Urahara, along with Tessai, grew up living with the Shihoin family. Tessai makes a comment early in Bleach that Yoruichi is Urahara's best friend. It hasn't been shown that they have any type of romantic feelings for one another, so far.