There is a known glitch in the game where even though you have completed all of a Sim's tasks, you will not be given BFF status with that Sim. It is not known what the cause of this is, but it may be possible that the glitch is caused when either when you delay doing a Sim's post-task, or some other reason.